Skip to content

[Isolated] Remove use of new_resource as this will be empty without a default value set #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2025
Merged

[Isolated] Remove use of new_resource as this will be empty without a default value set #3036

merged 5 commits into from
Oct 16, 2025

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Oct 7, 2025 •
edited
Loading

Description of changes

  • Remove use of new_resource as this will be empty without a default value set. We are using Chef Attributes as they are useful for CX to override using DevSettings/Cookbook/ChefAttributes
  • Install Pypi dependencies for Cookbook, Node and Cfn-bootstrap which we host in S3 in all supported regions, without this change the Build Image will fail in an isolated environment in commercial partition

Tests

  • Successful BUILD Image for x86 for all supported OSSes

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested a review from a team as a code owner October 7, 2025 21:17
@himani2411 himani2411 requested a review from a team as a code owner October 7, 2025 21:17
@himani2411 himani2411 added the 3.x label Oct 7, 2025
gmarciani
gmarciani approved these changes Oct 16, 2025
View reviewed changes
cookbooks/aws-parallelcluster-platform/recipes/install/cookbook_virtualenv.rb
virtualenv_path = cookbook_virtualenv_path
dependency_package_name = "pypi-cookbook-dependencies-#{node['cluster']['python-major-minor-version']}-#{node['kernel']['machine']}"
pypi_s3_uri = "#{node['cluster']['artifacts_s3_url']}/dependencies/PyPi/#{dependency_package_name}.tgz"
pypi_s3_uri = "#{node['cluster']['artifacts_s3_url']}/dependencies/PyPi/#{node['kernel']['machine']}/#{dependency_package_name}.tgz"
Copy link
Contributor

@gmarciani gmarciani Oct 16, 2025 •
edited by himani2411
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We separated folders by arhcitecture after upgrading python to 3.12.
This change requires the execution of a change to our bucket, that is to upload pypi deps for 3.12 into the correspoinding arch foilder.

Example:

s3://ap-northeast-1-aws-parallelcluster/archives/dependencies/PyPi/aarch64/

Approved.

@himani2411 himani2411 merged commit 2940239 into aws:release-3.14 Oct 16, 2025
36 of 48 checks passed
@himani2411 himani2411 mentioned this pull request Oct 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmarciani gmarciani gmarciani approved these changes

@hgreebe hgreebe hgreebe approved these changes

Assignees

No one assigned

Labels

3.x skip-changelog-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@himani2411 @gmarciani @hgreebe